Add Metal.jl support for lu_instance #468
Merged
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ArrayInterfaceMetalExt extension with proper lu_instance implementation - Fix issue where MtlArray lu_instance failed due to 0x0 matrix creation - Add Metal.jl to weakdeps and extensions in Project.toml - Add Metal.jl test to verify lu_instance works properly - Follow same pattern as CUDA extension for GPU array support Fixes #467 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 62.71% 62.17% -0.55%
==========================================
Files 12 13 +1
Lines 574 579 +5
==========================================
Hits 360 360
- Misses 214 219 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Simplify test to directly check that lu_instance returns an LU type - Make Metal tests only run on macOS using Sys.isapple() check - Add LinearAlgebra import for LU type check 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lu_instanceimplementation for Metal.jl arraysMtlArraylu_instancefailed due to 0×0 matrix creation causing Metal Performance Shaders framework errorChanges
ArrayInterfaceMetalExt.jlextension moduletest/gpu/metal.jlTest plan
lu_instancewithout errorsFixes #467
🤖 Generated with Claude Code